Conversation
jordevo
approved these changes
Jun 21, 2023
Add several TS configs shared
…to typescript-support
kikoruiz
commented
Feb 22, 2024
| 'react/jsx-runtime': path.resolve(pwd, prefix, 'node_modules/react/jsx-runtime.js'), | ||
| '@s-ui/react-context': path.resolve(path.join(pwd, prefix, 'node_modules/@s-ui/react-context')) | ||
| '@s-ui/react-context': path.resolve(path.join(pwd, prefix, 'node_modules/@s-ui/react-context')), | ||
| 'studio-utils': path.resolve(path.join(pwd, prefix, 'packages/ui/studio-utils')) |
Member
Author
There was a problem hiding this comment.
This is a backward-compatibility feature (for all the sites setting custom utils instead of using the @s-ui/studio-utils package).
carlosvillu
requested changes
Apr 29, 2024
andresz1
approved these changes
May 3, 2024
oegea
approved these changes
May 6, 2024
carlosvillu
approved these changes
May 6, 2024
nucliweb
approved these changes
May 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript Support for the whole SUI ecosystem (no breaking changes)
This PR is introducing the following changes:
♻️ Several packages have been upgraded in order to provide TypeScript support, always giving backwards compatibility:
@s-ui/bundler@s-ui/js-compiler@s-ui/lint@s-ui/mock@s-ui/react-context@s-ui/studio@s-ui/test-contract@s-ui/test✨ A new package has been created:
@s-ui/compiler-config🛠️ And another ones have been updated to be compliant with the new linting rules or just because they needed to be fixed:
@s-ui/consents@s-ui/helpers@s-ui/hoc@s-ui/react-head@s-ui/react-initial-props@s-ui/theme🧪 Added new server tests for
@s-ui/js-compilersince this tool now is responsible of traspiling JS and TS files.✅ Added type checking in CI and in the
pre-pushscript.🔒 Upgraded and synced all the TypeScript versions among all the tools and the monorepo.